-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grommet components reporting #2315
Open
AlfredPichard
wants to merge
11
commits into
master
Choose a base branch
from
report/grommet_reporting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredPichard
force-pushed
the
report/grommet_reporting
branch
from
July 6, 2023 14:08
9673a47
to
6b292af
Compare
AntoLC
force-pushed
the
report/grommet_reporting
branch
from
September 26, 2023 10:24
6b292af
to
f6da535
Compare
AntoLC
force-pushed
the
report/grommet_reporting
branch
from
October 4, 2023 10:49
f6da535
to
8a574ad
Compare
AntoLC
force-pushed
the
report/grommet_reporting
branch
from
November 9, 2023 13:26
8a574ad
to
b41dc67
Compare
AntoLC
force-pushed
the
report/grommet_reporting
branch
2 times, most recently
from
November 27, 2023 15:20
3f1914c
to
195ed6a
Compare
add a new config file for react-scanner to report the grommet components in marsha frontend. Ultimately, we would like to reduce the number of grommet components that we use in marsha. This first step gives us a state of the art of the current presence of it in our code.
- Move config files to src/frontend - Move report.json to src/frontend - Add command grommet-scan to package.json
Report for 26/09/2023 about the grommet component left.
Report for 27/09/2023 about the grommet component left.
The scan was scanning grommet-icons as well, which is not needed for the moment. This commit will allow us to scan only grommet and not grommet-icons.
Report for 29/09/2023 about the grommet component left.
Report for 04/10/2023 about the grommet component left.
Report for 09/11/2023 about the grommet component left.
Report for 22/11/2023 about the grommet component left.
Report for 27/11/2023 about the grommet component left.
Report for 05/12/2023 about the grommet component left.
AntoLC
force-pushed
the
report/grommet_reporting
branch
from
December 5, 2023 16:55
195ed6a
to
f864b91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR, not aimed to be merged, adds a new config file for react-scanner to report the grommet components in marsha frontend.
Ultimately, we would like to reduce the number of grommet components that we use in marsha. This first step gives us a state of the art of the current presence of it in our code.
Proposal
The goal is to keep track of the previous report files and use the config file regularly to visualize the progression of grommet removal.
Results
July 2023 :