Saved a couple of queries

openfoodfoundation · Sep 30, 2024 · b564e9c · b564e9c
1 parent 33b787a
commit b564e9c
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/Services/VoucherService.php b/app/Services/VoucherService.php
@@ -68,8 +68,11 @@ public static function collateVoucherAggregates(Voucher $voucher): void
             $voucher->voucher_short_code = null;
         }
 
-        $voucher->num_voucher_redemptions = VoucherRedemption::where('voucher_id', $voucher->id)->count();
-        $voucher->last_redemption_at      = VoucherRedemption::where('voucher_id')->max('created_at');
+        if($voucher->voucher_value_remaining != $voucher->voucher_value_original)
+        {
+            $voucher->num_voucher_redemptions = VoucherRedemption::where('voucher_id', $voucher->id)->count();
+            $voucher->last_redemption_at      = VoucherRedemption::where('voucher_id')->max('created_at');
+        }
 
         $voucher->saveQuietly();
     }