Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump database_cleaner from 1.99.0 to 2.0.1 #7081

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 12, 2021

Bumps database_cleaner from 1.99.0 to 2.0.1.

Changelog

Sourced from database_cleaner's changelog.

== 2.0.1 2021-02-04

== Bugfixes

== 2.0.0 2021-01-31

=== Changes

  • Rename url_whitelist to url_allowlist
  • Allowlist now supports regular expressions
  • Fixed Ruby 2.7 deprecation warnings

=== Breaking changes

  • Failed checks against the allowlist now raise UrlNotAllowed rather than NotWhitelistedUrl

== 2.0.0.beta2 2020-05-30

=== Features

=== Breaking changes

== 2.0.0.beta 2020-04-05

=== Breaking changes

  • Replace old shared RSpec examples with new "database_cleaner adapter" example: DatabaseCleaner/database_cleaner#629
  • split gem into database_cleaner-core and database_cleaner metagem.
  • Support Ruby versions 2.4, 2.5, 2.6, and 2.7, and drop support for older Rubies.
  • remove all deprecated code and get the specs passing again.
  • Split off all adapter gems into their own repos: DatabaseCleaner/database_cleaner#620
Commits
  • c889b94 release v2.0.1.
  • cc74d7d changelog for v2.0.1.
  • f8b7e05 delay running safeguards until right before cleaning begins. this allows for ...
  • 44bbfe5 remove notice now that master should be stable for the foreseeable future.
  • 51fb215 release v2.0.0.
  • 77f89a0 Remove whitespace markdown header.
  • 4d5ca13 Remove indentation on empty lines for consistency.
  • c6a401d Remove trailing whitespaces.
  • f7b9246 Merge pull request #660 from bpo/allowlist-regex
  • e4a1fe7 Merge branch 'master' into allowlist-regex
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Mar 12, 2021
@Matt-Yorkley
Copy link
Contributor

@dependabot-bot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/database_cleaner-2.0.1 branch from 1d3369a to 3d31b21 Compare March 16, 2021 10:45
Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some relevant test failures here...

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 24, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/database_cleaner-2.0.1 branch March 24, 2021 11:48
@luisramos0
Copy link
Contributor

@dependabot-bot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 4, 2021

Looks like this PR is closed. If you re-open it, I'll rebase it, as long as no-one else has edited it.

@luisramos0 luisramos0 restored the dependabot/bundler/database_cleaner-2.0.1 branch May 4, 2021 20:49
@luisramos0 luisramos0 reopened this May 4, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/database_cleaner-2.0.1 branch from 3d31b21 to d2cf1d0 Compare May 4, 2021 20:50
@luisramos0
Copy link
Contributor

ok, trying this one with rails 5.2

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #7081 (30e2be1) into master (01f8aff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7081   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         635      635           
  Lines       18128    18128           
=======================================
  Hits        16913    16913           
  Misses       1215     1215           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01f8aff...30e2be1. Read the comment docs.

@luisramos0 luisramos0 self-assigned this May 4, 2021
@andrewpbrett andrewpbrett requested a review from Matt-Yorkley May 7, 2021 15:38
Copy link
Contributor

@andrewpbrett andrewpbrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a green build is sufficient since we only use this in tests?

@luisramos0 luisramos0 force-pushed the dependabot/bundler/database_cleaner-2.0.1 branch from b60e19f to 913ba1c Compare May 9, 2021 20:44
@Matt-Yorkley
Copy link
Contributor

@dependabot-bot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 1, 2021

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Matt-Yorkley Matt-Yorkley force-pushed the dependabot/bundler/database_cleaner-2.0.1 branch from 460830a to 30e2be1 Compare June 1, 2021 17:50
@luisramos0
Copy link
Contributor

all right, looks very nice. lets merge?

I can then rebase the rails 6 PR to include this (there's a different/worse version of this in the rails 6 PR).

@Matt-Yorkley Matt-Yorkley merged commit 0d30e33 into master Jun 1, 2021
@Matt-Yorkley Matt-Yorkley deleted the dependabot/bundler/database_cleaner-2.0.1 branch June 1, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants