1766 registration scroll #3791
1766 registration scroll #3791
Conversation
|
nice, thanks for the PR! |
| = t(".registration_about_us") | ||
| %input#collapsible-registration-checklist.collapsible-checkbox{:type => "checkbox"} | ||
| %label.lbl-toggle{:for => "collapsible-registration-checklist"} | ||
| %h5= t(".registration_checklist")+":" |
There was a problem hiding this comment.
Hmm, a collapsed heading "You'll need:" doesn't look right... What do you think of changing the base translation to something similar to "What do I get?" in the second column, such as "What do I need?". To make it simple, it can be the same for both mobile and desktop.
| %input#collapsible-registration-outcome.collapsible-checkbox{:type => "checkbox"} | ||
| %label.lbl-toggle{:for => "collapsible-registration-outcome"} | ||
| %h5 | ||
| = t(".registration_outcome_headline") |
There was a problem hiding this comment.
Having this in a different line adds a space before the text, so the text is no longer aligned with the heading of the first set.
There was a problem hiding this comment.
yes, there is the space in the html, on my test it looks aligned anyway.
I'll make this a single line.
|
moving to in dev. |
|
@jazzdragon do you think you will pick this up again at some point? |
|
I can finish this, just a few things to fix. |
|
This is how it looks, I think it's good! ipad desktop I am going to follow @kristinalim recommendation and change the label to "What do I need?" |
…t looks better when collapsed
luisramos0
force-pushed
the
1766-registration-scroll
branch
from
58282db to
a370216
Compare
|
ok, I've merged master into this branch, addressed Kristinas feedback, fixed rubocop issues and tested locally. |
|
Windows 10 Edge 17: Windows 10 Firefox 63: MasOS Sierra Safari 10.1 Safari on iphone XS: Safari on Ipad Mini Chrome on Samsung Galaxy s10: Chrome Sony Xperia: Looking good, ready to go! |
|
Strong testing game 💪 |
What? Why?
Closes #1766
Add collapsible snippets of information in the registration introduction modal so the action button is visible on smaller screens without scrolling.
What should we test?
Release notes
Changelog Category: Added