[Products] Empty option on unit scale dropdown #12969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chahmedejaz
changed the title
chahmedejaz
added
bug-s3
chahmedejaz
force-pushed
the
task/12919-remove-empty-option-from-unit-scale-dropdown
branch
from
cd6b2ae
to
bafb881
Compare
dacook
reviewed
Nov 18, 2024
There was a problem hiding this comment.
From what I can see, the include_blank option was added here, perhaps to handle bad data.
Does this mean that every dropdown now has a blank "select unit scale" option? I think it would be ideal if we show "select unit scale" only when data is blank. Is that possible?
sigmundpetersen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):