Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec restock after order cancellation #12938

Merged
merged 3 commits into from
Oct 27, 2024
Merged

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 23, 2024

What? Why?

My big afternoon detour resulted in a simple spec. Now I know how to spec order cancellations for DFC Orders.

What should we test?

  • Specs only

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@mkllnk mkllnk added the technical changes only These pull requests do not contain user facing changes and are grouped in release notes label Oct 23, 2024
@mkllnk mkllnk self-assigned this Oct 23, 2024
@mkllnk mkllnk marked this pull request as ready for review October 23, 2024 05:38
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@rioug rioug merged commit 701504f into openfoodfoundation:master Oct 27, 2024
54 checks passed
@mkllnk mkllnk deleted the restock branch November 1, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical changes only These pull requests do not contain user facing changes and are grouped in release notes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants