Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUU] Activate admin_style_v3 for ~50% of users #12719

Merged

Conversation

dacook
Copy link
Member

@dacook dacook commented Jul 31, 2024

What? Why?

What should we test?

See issue

Release notes

I'm not sure exactly how many users are affected, but perhaps its time to start reporting as user-facing changes?

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

@dacook dacook self-assigned this Jul 31, 2024
@RachL RachL added pr-staged-fr staging.coopcircuits.fr and removed pr-staged-fr staging.coopcircuits.fr labels Jul 31, 2024
@RachL
Copy link
Contributor

RachL commented Jul 31, 2024

@dacook I've tried the following test:

  • disabling the feature, deploying: the feature gets activated for 50%
  • staged master then switched on to 2 groups (admins, new_...) + 25%. In that case deploying the PR didn't change the percentage.

Is this a risk in production too?

@dacook
Copy link
Member Author

dacook commented Jul 31, 2024

Hi @RachL , I think that's ok. Rails migrations are designed to run once on the database, and so it remembers if it's been run before, and doesn't retry the second time.
Just to be sure, I double-check on my machine to confirm that the 50% overwrites the 25%:

Before

Screenshot 2024-08-01 at 9 21 05 am

== 20240731065321 ActivateAdminStyleV3For50PcUsers: migrating =================
== 20240731065321 ActivateAdminStyleV3For50PcUsers: migrated (0.0282s) ========

After

Looks good ✅
Screenshot 2024-08-01 at 9 21 27 am

@dacook dacook added user facing changes Thes pull requests affect the user experience and removed feedback-needed labels Jul 31, 2024
@dacook
Copy link
Member Author

dacook commented Jul 31, 2024

PS @RachL can you confirm if this should be listed as a user-facing change?

@dacook dacook changed the title Activate admin_style_v3 for 50% of users [BUU] Activate admin_style_v3 for ~50% of users Jul 31, 2024
@dacook dacook merged commit 96355a1 into openfoodfoundation:master Jul 31, 2024
62 of 63 checks passed
@RachL
Copy link
Contributor

RachL commented Aug 1, 2024

@dacook awesome! Many thanks for double checking. I guess BUU is entering the "user facing change" category you are right 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUU] Activate admin_style_v3 for 50% of users
2 participants