Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUU] Activate admin_style_v3 for all super admins #12657

Merged
merged 1 commit into from
Jul 11, 2024
Merged

[BUU] Activate admin_style_v3 for all super admins #12657

merged 1 commit into from
Jul 11, 2024

Conversation

dacook
Copy link
Member

@dacook dacook commented Jul 10, 2024

⚠ Please use clockify code #7198 Back Office Uplift (Product) while reviewing or working on this task.

What? Why?

What should we test?

As on issue:

  1. Before staging he PR check super admins dont' see the new admin by default
  2. After staging the PR, check all super admins see it, they can remove the "admin" group but then no super admin can see the new UI unless there are in another group who has access
  3. Check this does not affect other users

@dacook dacook added the feature toggled These pull requests' changes are invisible by default and are grouped in release notes label Jul 10, 2024
@dacook dacook self-assigned this Jul 10, 2024
@dacook dacook force-pushed the buu/enable_feature_admin_style_v3_for_admins branch from b84ba09 to cb0a30e Compare July 10, 2024 01:55
rioug
rioug approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy !

@dacook
Copy link
Member Author

dacook commented Jul 11, 2024

This needs to be in the next release, but I forgot to request testing last night. So I'll test now and merge after second review.

@dacook dacook added the pr-staged-au staging.openfoodnetwork.org.au label Jul 11, 2024
@dacook
Copy link
Member Author

dacook commented Jul 11, 2024

Testing

✅ Feature toggle was enabled for "admins" group:
Screenshot 2024-07-11 at 10 10 54 am

Tested with my admin user (which is not explicitly enabled, and not a new user).
✅ New design appears.
Screenshot 2024-07-11 at 10 13 08 am

Logged in as a different user:
✅ Old design appears
Screenshot 2024-07-11 at 10 14 08 am

@dacook dacook removed the pr-staged-au staging.openfoodnetwork.org.au label Jul 11, 2024
@mkllnk mkllnk merged commit f1713b1 into openfoodfoundation:master Jul 11, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkllnk mkllnk mkllnk approved these changes

@rioug rioug rioug approved these changes

Assignees

@dacook dacook

Labels
feature toggled These pull requests' changes are invisible by default and are grouped in release notes
Projects
OFN Delivery board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUU] Activate admin_style_v3 for all super admins
3 participants
@dacook @mkllnk @rioug