-
-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Legacy Checkout] No shipping method option on checkout prevents completing the order and leads to Stripe charges #9614
Comments
Hi, thank you for this @filipefurtad0 ✨ A small feedback: it looks like paying with bank card didn't automatically lead to charges: I tested to pay twice with bank card (I think it was with two separate carts, so two different requests), but only one payment made it through Stripe. On the day of testing, there were two pending payments on my bank account, but only one payment appeared in Stripe. Weird! We told the producer to make refunds on Stripe - which is not easy because for most of the payments there were no emails associated.. Details on how refund works on Stripe:
|
Thank you @filipefurtad0 ! I think we have a clear documentation ❤️ . I don't think we can make the shop appear as closed because you can also end up with no shipping methods using tags... #9536 will add a proper message. I'm not sure we can do much more. Or do we have other ideas? So I think we can close here? @audez there are some delays before you can see everything appearing on Stripe and / or each stakeholders bankaccount. These delays also occurs in order for Stripe to only take the final correct action and not handle too many bank movement. That's why also payouts do not appear right away. |
IMO this could be split in 3 issues:
What do you think? |
Thanks for all the feedback! I've updated the issue (Expected behavior = open; Severity = s3).
Maybe adding a clear message on the legacy checkout (similar to #9145) + disabling the checkout button? I'm not sure we are still investing time fixing issues on legacy checkout. If not, agree to close - please feel free to 👍
Right, I keep forgetting this is used by some hubs to display products, as you've mentioned here. It feels clunky to me, but no strong opinion on this.
I'm not sure we'd really prevent that, but perhaps add a warning? Would be a new feature, but seems useful to me. PS:
@audez let's not test the app with real payments ☣️ moving the discussion into #testing |
Yes true, I think I lost a piece of thinking brain in the emergency stress... 😬☠️ After more research and according to comments on this and other issues ( #5423, #5559, #8219, #9145, #5950, #1343), I tried to summarized and was stroke with a writing fever.. Please feel free to comment or edit! ——————————— Warning the user
Warning the shop manager ——————————— But for now these 2 options don't seem to work: |
I'm closing the original isse: we won't fix legacy checkout now, let's focus on getting split checkout out 👍 |
Description
Aggregates #8219 and #9610.
Relates to #8974.
A shipping methods can be hidden from by:
If no shipping method is eligible for a given customer, then:
Legacy checkout - If a customer reaches the final stage of checkout and places the order without having an active checkout method then the checkout will fail. The user will see a first generic error messages:
The checkout failed. Please let us know so that we can process your order
, and then, when reattempting, another generic error message:Payment could not be processed, please check the details you entered
.If Stripe is used as a payment method this will lead to charges, although the order is not completed.
Split-checkout - the user cannot proceed to further steps, and can't really place the order - this is a good thing 💪
Expected Behavior
Under discussion, see below.
Actual Behaviour
Legacy checkout: Even if a user does not see any shipping method available, it is able to proceed to checkout, and place the order, which will lead to error unclear error messages and Stripe cards being charged.
Split checkout: Even if a user does not see any shipping method available, it is able to proceed to checkout, but cannot proceed to the next step in the checkout flow.
Steps to Reproduce
Animated Gif/Screenshot
Workaround
None, for the customer.
Severity
bug-s3: a feature is broken but there is a workaround
Keeping the severity from the most recent issue #8219.
Your Environment
Possible Fix
The text was updated successfully, but these errors were encountered: