Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise Registration - Scroll on first step #1766

Closed
lin-d-hop opened this issue Aug 12, 2017 · 16 comments · Fixed by #3791
Closed

Enterprise Registration - Scroll on first step #1766

lin-d-hop opened this issue Aug 12, 2017 · 16 comments · Fixed by #3791
Assignees
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue hackathon Issues for upcoming hackathons

Comments

@lin-d-hop
Copy link
Contributor

Stage one of the enterprise registration is not intuitive.

On my 13" screen you cannot see the Continue button at all. It is totally hidden making it unclear to the user what the next step is after they tick the box.

register

Can this be changed so that there is NO scroll on this screen, such that the full red button is displayed to the user. Perhaps something like this....

registerux

@sauloperez
Copy link
Contributor

sauloperez commented Aug 14, 2017

I experience the same problem. Is there any reason why we placed the content in a fixed-height box in the first place? I'd remove the limitation of the light grey box and allow the content to fill the page as usual. Only on very small screens you would need to scroll down your browser window.

@daniellemoorhead
Copy link
Contributor

I think it's fair to say that there wouldn't be a particularly good reason, so let's change it.

Could we but the angular for newbies label on this?

@daniellemoorhead daniellemoorhead modified the milestones: August dot point release, UK Current Aug 18, 2017
@sauloperez
Copy link
Contributor

sauloperez commented Aug 18, 2017

I'm not sure there's even angular there. It seems to be a CSS only thing

EDIT
Yes, after better looking at it is indeed an agular component (which I have no idea how it works).

@RachL
Copy link
Contributor

RachL commented Nov 19, 2017

Hi all ! I've noticed that on my tablet and my mobile the scroll inside this popin is not possible. When I switch the device position, my screen is not high enough to see the popin entirely and therefore I cannot access the button.
In my opinion, the popin should open as a new page / tab in the mobile/tablet browser rather than a popin. What do you think ? Shall I create another issue or can it be part of this one ? Thanks :)

screenshot_20171119-162814

@sauloperez
Copy link
Contributor

Ok, I got tired of this issue 😅 I'm going to find the culprit and fix it.

@sauloperez sauloperez self-assigned this Dec 1, 2017
@lin-d-hop lin-d-hop removed this from the UK Current milestone Dec 18, 2017
@sauloperez
Copy link
Contributor

I haven't got the chance to look at it yet, so anyone can take it.

@kristinalim
Copy link
Member

I was able to reproduce the same issue which @RachL reported for small screens. The area is scrollable, but content is hidden beyond the bottom of the visible area:

20180819145101-enterprise-registration-small-button

Work is already in #2544, but the status of this issue needs to be checked with those changes.

@daniellemoorhead
Copy link
Contributor

good pick up @kristinalim, I added this issue number to your PR #2544 explanation so we remember to close this again once the PR is merged. 😄

@kristinalim
Copy link
Member

After #2544 is merged, the button in small screens will already be clickable, but the user would still have to scroll to see this.

Scrolling seems necessary if we keep the contents as they are. Here's the full length of the modal on an example small screen:

20180910194657-enterprise-registration-small

These would bring the button higher in the page:

  1. Have two buttons instead of one for small screens: one above the "You'll need" text and retaining the existing one below.
  2. Collapse the text under headings "What are the requirements?" and "What do I get?"

The first one would be easier, but the second one would give a better experience I think.

I'm not a UX expert. 😁 Do you have better ideas?

@sauloperez
Copy link
Contributor

Option 2 sounds good to me.

@kirstenalarsen
Copy link
Contributor

kirstenalarsen commented Sep 11, 2018 via email

@sauloperez
Copy link
Contributor

and what about a "See more" link to show that "What do I get" section (maybe rephrased)?

@myriamboure
Copy link
Contributor

I was just testifying while a user was setting up in front of me a hub, that when reaching the page "add promo image" she couldn't see the "next" button and the scroll didn't appear, so she just couldn't move on, she had to use tabulation to randomly "find" the next button to move to last page of the registration modal. I guess this is link to that issue, right? We are running on v1.18 so maybe some recent fix did solve that... but the scroll bar seems to randomly not appear on some computers... (I have also seen that on producer modals on the map, on some screens, scroll was not appearing).

@HugsDaniel HugsDaniel removed their assignment Oct 9, 2018
@sigmundpetersen sigmundpetersen added the bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. label Oct 9, 2018
@RachL RachL added the hackathon Issues for upcoming hackathons label Apr 10, 2019
@alondahari
Copy link
Collaborator

I'm going to take this issue, and implement the second solution above, I agree that it seems like better UX.

@myriamboure I'm not sure but I think what you're describing might deserve it's own ticket.

I don't have write access to this board, so if someone with permissions sees this, please assign me and move this ticket to "in dev". Thanks.

@sigmundpetersen
Copy link
Contributor

sigmundpetersen commented May 2, 2019

Hey @jazzdragon great thanks! I moved it along to In Dev. To be assigned you need to be added to the GH organization by an admin 👍 If you connect the upcoming PR to this issue we can follow them together either way.

@lin-d-hop
Copy link
Contributor Author

@jazzdragon You should have an invite in your inbox. Once you accept you'll be able to assign yourself :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-s3 The bug is stopping a critical or non-critical feature but there is a usable workaround. good first issue hackathon Issues for upcoming hackathons
Projects
None yet
Development

Successfully merging a pull request may close this issue.