Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire JB's ssh access #906

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 20, 2023

JB left the organisation and I removed his SSH key from all servers already:

ansible-playbook playbooks/remove_ssh_keys.yml --limit all_prod,all_staging -e "{'remove_users_sysadmin':[jb]}"

This change makes sure that we don't add it again.

@mkllnk mkllnk self-assigned this Oct 20, 2023
Copy link
Contributor

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

I note that we don't actually remove the key from this repo. I can't think of a good reason to remove it, or keep it, so will do nothing ;)

@dacook dacook merged commit b763410 into openfoodfoundation:master Oct 20, 2023
2 checks passed
@mkllnk mkllnk deleted the retire-jb branch October 20, 2023 05:19
@mkllnk
Copy link
Member Author

mkllnk commented Oct 20, 2023

We need to keep the key to remove it from files. Otherwise we don't know which line to remove. But we could prune the retired keys at some point. And I could imagine that there are many other unused keys in the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants