Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI build on Github Actions #903

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 9, 2023

The build takes best part of an hour but it does run the whole suite and makes sure that the app is running on a fresh container.

We couldn't install all our dependencies because of conflicting
versions:

```
The following packages have unmet dependencies:
libgd-dev : Depends: libgd3 (= 2.2.5-5.2ubuntu2.1)
  but 2.3.3-9+ubuntu20.04.1+deb.sury.org+1 is to be installed
```
This is actually unrelated. I mixed up roles while updating a dependency
but it doesn't hurt to stay up-to-date. So I keep this commit in.
Hopefully the new version will create postgres users with the defined
permission to create databases.
Since we are importing only parts of another role, we missed to include
this new part after some update. This should give the database user the
permission to create its database again.
@mkllnk mkllnk self-assigned this Oct 9, 2023
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💐 Great job!!! 🎉

It's worth noting that any other devs will need to run bin/setup to download the latest requirements.
But I think I'm the only other dev using this at the moment, so I'll just do that myself now ;)

@dacook dacook merged commit 454a453 into openfoodfoundation:master Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants