Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name of multi_redis repository #897

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

mkllnk
Copy link
Member

@mkllnk mkllnk commented Oct 2, 2023

Matt changed the underscore to a dash and downloading the role failed.

- downloading role 'multi_redis', owned by libre_ops
- downloading role from https://github.com/libre_ops/multi_redis/archive/1.0.1.tar.gz
Error: ]: failed to download the file: HTTP Error 404: Not Found
Warning: : - libre_ops.multi_redis was NOT installed successfully.
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

https://github.com/openfoodfoundation/ofn-install/actions/runs/6374617784/job/17299450784

Matt changed the underscore to a dash and downloading the role failed.
@mkllnk mkllnk self-assigned this Oct 2, 2023
@dacook
Copy link
Member

dacook commented Oct 4, 2023

But I guess this is why he changed it...

ERROR! the role 'libre_ops.multi_redis' was not found in /home/runner/work/ofn-install/ofn-install/tests/../playbooks/roles:/home/runner/work/ofn-install/ofn-install/community:/home/runner/work/ofn-install/ofn-install/roles:/home/runner/work/ofn-install/ofn-install/tests/../playbooks

The error appears to be in '/home/runner/work/ofn-install/ofn-install/playbooks/provision.yml': line 70, column 7, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


    - role: libre_ops.multi_redis
      ^ here

https://github.com/openfoodfoundation/ofn-install/actions/runs/6375402638/job/17301125218?pr=897

Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't fix it :(

@mkllnk
Copy link
Member Author

mkllnk commented Oct 4, 2023

This doesn't fix it :(

Oh, it fixes the installation and linting. But I need to add another change.

@mkllnk mkllnk requested a review from dacook October 4, 2023 04:13
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On to the next step :)

Unable to correct problems, you have held broken packages.

Reading package lists...\nBuilding dependency tree...\nReading state information...\nSome packages could not be installed. This may mean that you have\nrequested an impossible situation or if you are using the unstable\ndistribution that some required packages have not yet been created\nor been moved out of Incoming.\n
The following information may help to resolve the situation:

The following packages have unmet dependencies:
libgd-dev : Depends: libgd3 (= 2.2.5-5.2ubuntu2.1) but 2.3.3-9+ubuntu20.04.1+deb.sury.org+1 is to be installed

@mkllnk
Copy link
Member Author

mkllnk commented Oct 4, 2023

On to the next step :)

Yes, same problem as before. The GH Actions image seems to be in a different state to our standard Ubuntu images. So we could try to fiddle with the installed packages or spin up our own container...

@mkllnk mkllnk merged commit feac97e into openfoodfoundation:master Oct 4, 2023
1 of 2 checks passed
@mkllnk mkllnk deleted the libre-ops branch October 4, 2023 21:56
@sigmundpetersen
Copy link
Contributor

Maybe some inspiration to get from this similar issue actions/runner-images#2139
Looks like adding a workaround of cleaning the dependencies before reinstalling libgd-dev

@mkllnk
Copy link
Member Author

mkllnk commented Oct 8, 2023

Maybe some inspiration to get from this similar issue actions/runner-images#2139
Looks like adding a workaround of cleaning the dependencies before reinstalling libgd-dev

Ah, yes, I came to the same workaround. It works but a running build then revealed a bug in our setup. I'm still working on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants