Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix All AS3 DisplayObject Getters/Setters #4

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

Fancy2209
Copy link
Contributor

No description provided.

@joshtynjala joshtynjala merged commit 51eae89 into openfl:master Feb 27, 2024
1 check passed
@joshtynjala
Copy link
Member

@Fancy2209 I just realized... in #3, you modified openfl/display/DisplayObject.as, but in #4, you modified flash/display/DisplayObject.as. Both files should probably include the full set of changes to all properties.

@Fancy2209
Copy link
Contributor Author

@Fancy2209 I just realized... in #3, you modified openfl/display/DisplayObject.as, but in #4, you modified flash/display/DisplayObject.as. Both files should probably include the full set of changes to all properties.

I just realized the same looking in jpexs. Just made #5
By the way, why is the flash package even a thing? it causes issues
imagem

@joshtynjala
Copy link
Member

By the way, why is the flash package even a thing?

Presumably, so that you can re-use existing code without changing all of the imports from flash to openfl.

Relatedly, in the Haxelib version, Lime/OpenFL automatically adds --remap flash:openfl to the generated .hxml file. Same idea.

@Fancy2209
Copy link
Contributor Author

I remember trying it and it gave a implicit coercion or something of the sort

@joshtynjala
Copy link
Member

I remember trying it and it gave a implicit coercion or something of the sort

Yeah, that makes sense. AS3 wouldn't have any reason to believe that openfl.display.DisplayObject is related to flash.display.DisplayObject. With this in mind, the flash package externs should probably be removed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants