Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first added in 3dad6d8, without explanation. I think it's time to remove it.
Considerations:
@:generic
may make the code faster. However, this isn't performance-critical code, and any improvements are likely to be vanishingly small.@:generic
increases the size of the output.@:generic
prevents casting toPromise<Dynamic>
, which forced a slightly more verbose implementation ofFutureWork
. Technically this enforces type safety, but usually we don't worry about that sort of thing. If a user's going to useDynamic
, they accept responsibility for the risks.