-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge develop into feature branch #1842
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hs, font glyphs, ...)
…e included in some toolchains and was deprecated in C++17 anyway).
Casting `const char*` → `char*` is bad form, and we'd rather copy the string than do that. However, `GetGlyphIndex()` now takes a const, so neither workaround is needed.
Also, use `hxs_utf8()` for consistency.
…ets. If you have a `<section if="cpp">` tag in your project.xml, you don't want it to be active just because a system environment variable happens to be named "cpp". You only want it active if actually targeting C++.
Ignore system environment variables with the same name as common targets.
[ci] Add mac arm64 ndll to lime package
I'd rather duplicate the SDK version check, not the math.
`GameActivity` doesn't print any other messages, so this seems out of place. Plus, it would happen every time even if there's no vibration ongoing.
Android vibration fixes.
UNICODE fixes (clipboard, window title, file dialogs, paths, font glyphs, ...)
…/opt/hombrew/lib to rpath of lime.ndll" This reverts commit 4793649. Didn't work with Haxe/Neko installed from Apple Silicon Homebrew because Lime tools couldn't link to Neko.
…esn't support x86_64 yet
…e architectures instead of defaults (closes #1819) Still supports -32 and -64, though, for backwards compatibility. We could consider removing those in Lime 9.
The main thread can easily look these up by ID, and in HTML5, sending the full `JobData` can cause errors.
`__activeThreads` and `__idleThreads` only need to be allocated for multi-threaded pools. Plus, there's no benefit to using a `List` here; we only add to and remove from the end. And finally, checking `event.job == null` instead of `isOfType()` is faster and avoids an issue in HTML5. Sadly it is less safe, so we might need to revisit it eventually.
It looks like we'll want to take `BackgroundWorker` in a different direction, so for the moment it's safest not to change anything about it. That way, there's only one historical version to maintain backwards compatibility with.
As with `BackgroundWorker`, we're postponing major changes to give us more time to consider.
While I put a lot of effort into that guide, we're changing several things suddenly, and I don't have time to make sure it's up to date.
Restore old `Future` and `BackgroundWorker` behavior.
These were added for drop-in compatibility with `BackgroundWorker`, but we might not need that level of compatibility. We can discuss adding these back later if there's demand.
Hopefully my last before 8.2.0.
Originally had docs for this but we nixed it for a while so they never got added.
Forgot the properties.
We need more docs!
Missing docs.
Offering four options makes the underlying code more complicated for minimal benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.