Only escape backslashes in Android paths. #1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither .properties nor .gradle files require anything else to be escaped, and in .gradle files, escaping anything else is incorrect.
I think most of these weren't well-tested in the first place. On Linux* I was able to use the
#!=
characters without any trouble at all, while colons caused hxcpp to be unable to find the g++ executable. (For the latter, it makes no difference whether we do or don't escape it, because hxcpp doesn't get the file path from Lime.)*And it's clear this wasn't well-tested on Windows either, since it escapes the colon in "C:".
Supersedes #1720, or vice versa.