Code to be corrected

[dsuponitskiy]

1. src/binfhe/include/rgsw-cryptoparameters.h: in RingGSWCryptoParams()
   instead of "if ((method == LMKCDEY) & (numAutoKeys == 0))" there should be "if ((method == LMKCDEY) && (numAutoKeys == 0))"

2. FindInVector() is defined in 2 different classes: DiscreteGaussianGeneratorImpl and in BaseSampler. The function return values differ by 1.

3. src/pke/lib/encoding/packedencoding.cpp: bool PackedEncoding::Encode(): "size_t i;" is declared twice outside of the loop in this function. Should not be outside the corresponding loops

4. - Add
   #include "math/hal/basicint.h" // for MAX_MODULUS_SIZE
   to constants.h and remove
   #include "math/math-hal.h"
   #include "lattice/constants-lattice.h"
   - Add #include "lattice/constants-lattice.h" to rlwe-cryptoparameters.h

5. Replace "DCRTPoly" with "Element" in multiple files and discuss the changes with a scientist. Examples:

   • src/pke/include/schemebase/base-parametergeneration.h
   • src/pke/include/schemebase/base-leveledshe.h
   • src/pke/include/schemebase/base-scheme.h
   • src/pke/lib/schemebase/base-leveledshe.cpp

   Make ParamsGenBGVRNS(), ParamsGenCKKSRNS() and ParamsGenBFVRNS() non-virtual in base-scheme.h.

6. utils/exception.h: make all get functions const for OpenFHEException

7. Remove _MAKE_UNIQUE and make_unique from src/core/include/utils/memory.h and remove includes of memory.h where they are not needed

8. Add "std::" to ceil(), floor(), log2(), pow(), sqrt() etc.

9. src/pke/include/scheme/ckksrns/ckksrns-fhe.h:

   • Make both m_paramsEnc and m_paramsDec in CKKSBootstrapPrecom std::vector<unt32_t>. The current type is std::vector<int32_t>.
   • Make all data members of class CKKSBootstrapPrecom private

10. Change the name COMPRESSION_LEVEL (constants.h) to Camel case

11. Add either NOT_SET or INVALID_VALUE to all enums in constants.h

12. See if we can replace the __builtin_*() functions with __FILE__, __LINE__ and __FUNCTION__ in OpenFHEException as the functions are available with gcc only - This can not be done as the macros are replaced with information from exception.h by the preprocessor at compile time.

13. Remove the return value (eval_key_map) from EvalSumRowsKeyGen()/EvalSumColsKeyGen() and the EvalKey parameter from EvalSumRows()/EvalSumCols()

14. Serialize/Deserialize functions should be "void" instead of returning true/false. Errors should be handled with exceptions

15. Remove PublicKey from the parameter list #645

16. Mark MATHBACKEND=2 deprecated #678

17. Mark classes from "utils/exception.h" deprecated, so we can remove OPENFHE_THROW_OLD along with them. Is ThreadException used at all? #680

18. Rename the function member PrintValue() to GetFormattedValues() and move it simple implementation to PlaintextImpl "precision". Use it in operator<<(). The function should be overloaded in CKKSPackedEncoding only. Also check doprint(), PrintParameters() and print() (in src/pke/include/metadata.h). GetFormattedValues() should stay public in case someone needs to change the precision (like in openfhe-python).

19. Replace sharingScheme types "additive" and "shamir" with enums

20. Get rid of "int"

21. zzz