Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce to working language-configuration set #46

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: reduce to working language-configuration set #46

merged 3 commits into from
Aug 4, 2023

Conversation

d-jeffery
Copy link
Collaborator

@d-jeffery d-jeffery commented Aug 2, 2023 •
edited
Loading

Description

  • Removed code that was not being used by language-configuration
  • Added onEnter rules for text based indentation
  • Tested manually for what felt expected when writting

Open to expanding further with more developer experience needed

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery marked this pull request as ready for review August 3, 2023 00:01
@d-jeffery d-jeffery requested a review from a team as a code owner August 3, 2023 00:01
@adriantam adriantam merged commit aa16faa into main Aug 4, 2023
4 checks passed
@adriantam adriantam deleted the fix/language-config branch August 4, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Fix language configuration
2 participants
@d-jeffery @adriantam