-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support configurable token endpoint #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just saw PR are no longer being accepted here. So closing this |
4 tasks
rhamzeh
previously approved these changes
Oct 21, 2024
evansims
approved these changes
Nov 4, 2024
evansims
changed the title
feat/(token): token endpoint is now configurable
feat: support configurable token endpoint
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
_parse_issuer
function, enhancing the validation and normalization of issuer URLs for OAuth token requests. It ensures URLs adhere to standards by verifying schemes and appending a default path if needed.Description
This pull request introduces a new function,
_parse_issuer
, to the authentication system, specifically designed to enhance the validation and normalization of issuer URLs used in OAuth token requests.This function systematically checks and corrects the structure of the issuer URL, ensuring it adheres to expected standards, such as including a valid scheme (http or https) and appending a default endpoint path if none is provided.
Additionally, comprehensive tests have been added to validate the functionality of this new method against various edge cases and common URL formatting errors.
Changes
_parse_issuer
function to enhance issuer URL validation inCredentials
._parse_issuer
to ensure robust handling of a variety of URL inputs.References
This PR closes issue #136.
Review Checklist
main