Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: algebaric operation loop should be classified as loop in compile time #350

Open
wants to merge 1 commit into
base: feat/node_list_for_cycle
Choose a base branch
from

Conversation

adriantam
Copy link
Member

Description

If the graph's loop only consists of RewriteEdge or ComputedEdge, classified them as compile time loop instead of runtime loop.

This means the following type of model

model
  schema 1.1
type user

type document
  relations
    define admin: [user]
    define action1: admin and action2 and action3
    define action2: admin and action1 and action3
    define action3: admin and action1 and action2

will be classified as compile time loop instead of runtime loop. This allows us to match the current openfga server behaviour.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant