Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run lexer generation before parser generation #55

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

ewanharris
Copy link
Member

Description

We've been seeing intermittent failures with errors like below, after some investigation it became apparent that every instance of this error occurred when generateParser ran before generateLexer. So force the generateLexer task to run first using dependsOn

> Task :compileJava FAILED
/Users/ewan/dev/git/openfga/intellij-plugin/src/main/java/dev/openfga/intellijplugin/parsing/OpenFGAParserDefinition.java:50: error: cannot find symbol
        return new OpenFGAParser();
                   ^
  symbol:   class OpenFGAParser
  location: class OpenFGAParserDefinition

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested review from a team as code owners September 10, 2024 08:09
@ewanharris ewanharris merged commit d45fe7c into main Sep 10, 2024
14 checks passed
@ewanharris ewanharris deleted the build/fix-task-order branch September 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants