Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test to cover not sending empty array when other has data #44

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

ewanharris
Copy link
Member

Description

Adds the Deletes property to the test to ensure that we don't pass this when it is empty. Given that we don't match on body this isn't really much gain but it will help to ensure we maintain this in future if we improve testing.

References

Part of openfga/sdk-generator#299
Generated from openfga/sdk-generator#306

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@ewanharris ewanharris requested a review from a team as a code owner February 12, 2024 19:38
@rhamzeh rhamzeh added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit 6fdff8b Feb 12, 2024
12 of 13 checks passed
@rhamzeh rhamzeh deleted the chore/add-deletes-to-write-call branch February 12, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants