Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: support multiple test files #8

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

le-yams
Copy link
Contributor

@le-yams le-yams commented Apr 4, 2024

Hello there,

Here is a proposal for supporting multiple test files.

Description

The action would have 2 optional parameters:

  • test_path to specify a test file or folder (default value .)
  • test_files_pattern to specify the pattern used to match test files (default value *.fga.yaml)

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@le-yams le-yams marked this pull request as ready for review April 4, 2024 15:33
@le-yams le-yams requested a review from a team as a code owner April 4, 2024 15:33
@le-yams le-yams force-pushed the feat/multiple_files_support branch from e4a7df5 to 80df861 Compare April 4, 2024 15:37
@le-yams le-yams force-pushed the feat/multiple_files_support branch from 80df861 to 8d9e203 Compare April 4, 2024 15:47
@rhamzeh
Copy link
Member

rhamzeh commented Apr 4, 2024

/easycla

@rhamzeh
Copy link
Member

rhamzeh commented Apr 4, 2024

Thanks for this @le-yams!

@rhamzeh
Copy link
Member

rhamzeh commented Apr 4, 2024

Going to delay merging - I know you've signed the CLA, but just trying to get the bot here. I don't think that will need any action items from you, so expect this to be merged soon!

@rhamzeh rhamzeh merged commit bbdc3f5 into openfga:main Apr 4, 2024
2 checks passed
@big-kahuna-burger
Copy link
Contributor

Good stuff, but I think we should get this in CLI and then just pass the arg as is.

  • Opened up an issue there, will see if I can make something happen during the holidays now.
  • We need to note the breaking change, so it won't fail on people once a release gets cut out (those who don't follow naming convention, like .fga.yaml will get errors)

@le-yams le-yams deleted the feat/multiple_files_support branch May 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants