Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SIGTERM handling for node templates #281

Closed
wants to merge 1 commit into from
Closed

add SIGTERM handling for node templates #281

wants to merge 1 commit into from

Conversation

francisdb
Copy link

fixes #273

@derek
Copy link

derek bot commented Feb 17, 2022

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "[email protected]"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Signed-off-by: Francis De Brabandere <[email protected]>
@derek derek bot removed the no-dco label Feb 17, 2022
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexellis this looks good, it is what we are also doing on a recent project

@alexellis
Copy link
Member

@francisdb thanks for contributing.

We need you to fill out the PR template which is part of the contributing process

https://raw.githubusercontent.com/openfaas/templates/master/.github/PULL_REQUEST_TEMPLATE.md

Alex

@francisdb francisdb closed this by deleting the head repository Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS templates don't react to SIGTERM
3 participants