-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS templates don't react to SIGTERM #273
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The js templates using
express
are missing SIGTERM handlingExpected Behaviour
A SIGTERM on the container should stop it
Current Behaviour
Nothing happens, the shutdown times out and the container is hard killed
Are you a GitHub Sponsor (Yes/No?)
Check at: https://github.com/sponsors/openfaas
The company I work for is sponsoring (waylay.io)
Which Solution Do You Recommend?
Any of the solutions documented here, I guess the first one is enough
https://expressjs.com/en/advanced/healthcheck-graceful-shutdown.html
Steps to Reproduce (for bugs)
Context
This is just an observation and I suspect not handling shutdown properly can interfere with the kubernetes scheduler causing redeploys and scaling to be slower
The text was updated successfully, but these errors were encountered: