Support scraping metrics from function pods for custom scaling types #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support scraping metrics from function pods directly. This allows users to provide metrics for custom scaling types. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
The load used to be sealed by the autoscaler when it queried the load metric. To support custom load recording rules that do not need to be ceiled ceiling is now done on the individual recording rules that need it. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <[email protected]>
welteki
force-pushed
the
function-metrics
branch
from
b9103a8
to
2dfa9e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Scrape metrics from functions directly
Support scraping metrics from function pods directly. This allows users
to provide metrics for custom scaling types.
Function pods that have the annotation
prometheus.io.scrape: truewill get scraped. Optionally the port and endpoint can be configured through additional annotations:prometheus.io.path:,prometheus.io.portCeil load values for scaling in recording rule
The load used to be sealed by the autoscaler when it queried the load
metric. To support custom load recording rules that do not need to be
ceiled ceiling is now done on the individual recording rules that need
it.
Why is this needed?
Who is this for?
What company is this for? Are you listed in the ADOPTERS.md file?
How Has This Been Tested?
Deployed function with the annotation
prometheus.io.scrape: truein different namespaces and verified function pods were included in the Prometheus targets though the UI.This test was repeated without a ClusterRole for Prometheus to verify function pods in the default function namespace can be scraped.
Types of changes
Checklist:
git commit -s