Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/#770 negative load shedding for debugging purposes #771

Merged

Conversation

CarlosEpia
Copy link
Contributor

Deals with #770

@CarlosEpia CarlosEpia self-assigned this Nov 8, 2024
@@ -702,6 +707,31 @@ def load_shedding(self, temporal_disaggregation=False, **kwargs):
"Generator",
)

if negative_load_shedding:
# Add negative load shedding generators for AC buses
ac_buses = network.buses[network.buses.carrier == "AC"].index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way the negative load shedding can not solve the problems for the EV buses. Could you add the EV buses here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. I made some changes in 97642ab to make the allocation of the negative load shedding carrier flexible.

Copy link
Contributor

@ClaraBuettner ClaraBuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it since I guess you already did that. The code looks fine, so I approve this PR.

@CarlosEpia CarlosEpia merged commit a6a3005 into dev Nov 14, 2024
6 checks passed
@CarlosEpia CarlosEpia deleted the features/#770-negative-load_shedding-for-debugging-purposes branch November 14, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants