-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/#770 negative load shedding for debugging purposes #771
Features/#770 negative load shedding for debugging purposes #771
Conversation
etrago/tools/utilities.py
Outdated
@@ -702,6 +707,31 @@ def load_shedding(self, temporal_disaggregation=False, **kwargs): | |||
"Generator", | |||
) | |||
|
|||
if negative_load_shedding: | |||
# Add negative load shedding generators for AC buses | |||
ac_buses = network.buses[network.buses.carrier == "AC"].index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way the negative load shedding can not solve the problems for the EV buses. Could you add the EV buses here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. I made some changes in 97642ab to make the allocation of the negative load shedding carrier flexible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test it since I guess you already did that. The code looks fine, so I approve this PR.
Deals with #770