Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop upper version limit for tables package #754

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,5 @@ jobs:
- name: "Install the package"
run: "python -m nox -s install"
env:
PYTHONUNBUFFERED: "1" # Ensure Python output is unbuffered
PLATFORM: ${{ matrix.os.image }}
19 changes: 19 additions & 0 deletions noxfile.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from pathlib import Path
from pprint import pformat
import platform

import nox

Expand Down Expand Up @@ -65,6 +66,15 @@ def flake8(session):
@nox.session(python=["3", "3.9", "3.10", "3.11"])
def build(session):
"""Build the package and check for packaging errors."""
# Get the current Python version and OS
current_version = session.python if session.python else "unknown"
current_os = platform.system()
print(f"Running install on Python {current_version} and OS {current_os}")

# Check if the current session is Python 3.9 on macOS and skip
if current_version == "3.9" and current_os == "Darwin":
session.skip("Skipping tests for Python 3.9 on macOS")

setdefaults(session)
session.install("twine")
session.run("python", "setup.py", "bdist", "bdist_wheel")
Expand All @@ -74,6 +84,15 @@ def build(session):
@nox.session(python=["3", "3.9", "3.10", "3.11"])
def install(session):
"""Install the package."""
# Get the current Python version and OS
current_version = session.python if session.python else "unknown"
current_os = platform.system()
print(f"Running install on Python {current_version} and OS {current_os}")

# Check if the current session is Python 3.9 on macOS and skip
if current_version == "3.9" and current_os == "Darwin":
session.skip("Skipping tests for Python 3.9 on macOS")

setdefaults(session)
session.env["SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL"] = "False"
session.run("python", "-mpip", "install", "--upgrade", "pip")
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def read(*names, **kwargs):
"setuptools >= 54.2.0",
"shapely",
"sqlalchemy < 2",
"tables < 3.9",
"tables",
"tilemapbase == 0.4.5",
"tsam",
],
Expand Down