Update module structure #714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the H2_grid nodes were not clustered at all since "H2" was never in the list of carriers
There were several problems with the import when there is an io module in the working directory. To avoid these, the module remains a submodule of tools
|
@ulfmueller: Do you have any thoughts/concerns on this? |
ulfmueller
approved these changes
Feb 12, 2024
|
Closed in favor of #752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch slightly adjusts the structure of etrago. There are now more submodules, and especially the tools module is now smaller.
The different modules are quite similar to the flow-chart we often use to show the functionalities of eTraGo, which makes it easier to combine both. The structure now looks like this:
-- etrago.analyze.calc_results
-- etrago.analyze.plot
-- etrago.cluster.electrical
-- etrago.cluster.gas
-- etrago.cluster.snaphot
-- etrago.cluster.spatial
-- etrago.disaggregate.spatial
-- etrago.disaggregate.temporal
-- etrago.execute.grid_optimization
-- etrago.execute.market_optimization
-- etrago.execute.sclopf will be added
-- etrago.tools.io
--- etrago.tools.io.db
-- etrago.tools.constraints
-- etrago.tools.extendable
-- etrago.tools.utilities
I am not sure if that is the very best structure but it is in my opinion already an improvement to the modules before, where many things were in the tools module. It might make sense to move e.g. constraints and extendable to the execute module. We can discuss the structure. This setting is already working, the tool itself and als the rtd is working fine.