Fix dc_loading for line loading plot #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosEpia
approved these changes
Nov 16, 2023
|
The loading plot is working correctly. I did the mentioned change regarding the problem with OSM background map. |
If the osm map is used as a background grid, the crs is updated. In order to avoid conflicts with the geographical_boundaries, these are now overwritten by the transformed coordinates from the osm parameter.
ClaraBuettner
commented
Nov 20, 2023
etrago/tools/plot.py
Outdated
| @@ -2703,7 +2717,6 @@ def plot_grid( | |||
| flow=flow, | |||
| title=title, | |||
| geomap=False, | |||
| boundaries=geographical_boundaries, | |||
There was a problem hiding this comment.
Removing this line created some problems because the defined geographical boundaries were not used anymore. I fixed this in my latest commit.
|
All the plots are working as expected. This branch can be merged into dev. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixed the visualization of line_loading. Could you double-check that it works as expected?