-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/#663 update pypsa version #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pypsa==0.25.2, the clustering strategy is 'consense' per default. That created problems for some columns, which are solved by adding specific strategies for these columns.
From pypsa>0.25.1 on, the aggregation of already solved networks creates problems in pypsa. It looks for all time series variables in the static dataframe, which leads to key errors, eg. for 'p' of generators. This commit aggeragted the new generators using pandas functions.
Should be removes/replaced later on
Within pypsa's network clustering, all output timeseries are filled with 0.0. This results into problems in the following clustering steps. To avoid that, the output timeseries data is replaced with empty dataframes.
PyPSA's networkclustering now deletes timeseries that only inlcude the default value. When running smaller example calculations eith only a few snapshots, it could happen, that the p_max_pu time series of some wind or solar generator is always 1.0 To avoid key errors in these cases, it was required to not use the carrier to decide if a generator has a p_max_pu time series but directly look at the existing columns.
…uded Before it was checked if the last snashot of the disaggreagted timeseries is included which led to duplicated index values.
ulfmueller
approved these changes
Dec 1, 2023
ulfmueller
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663
eTraGo now needs python>3.9