-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#532 update to plotpy #568
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Alonso,
I tested the main features of the plot_grid function and left some comments. Please check and apply them. Furthermore, please check each one of the options we have for the parameters line_colors and bus_colors before the next review.
Hi @CarlosEpia I made some changes and now its only plotting AC buses in expansion_abs plot |
Hi @CarlosEpia This is how etrago.plot_grid(line_colors= "v_nom" , bus_sizes= 0.001) looks like now. I have just pushed the changes |
Hi @CarlosEpia |
Hi Alonso. Please send me by email plots where we can see the current state of each plot available in the function plot_grid(). Then I will proceed to check the code. |
The described problems were solved in the commits 569303d, 55bfbdd and 82eae3a |
I just went through the different plots and they look OK. I think it is worth giving it a try @ClaraBuettner. |
etrago/tools/plot.py
Outdated
@@ -1607,60 +1673,78 @@ def calc_network_expansion(network, method="abs", ext_min=0.1): | |||
|
|||
Returns | |||
------- | |||
all_network : :class:`pypsa.Network | |||
network_c : :class:`pypsa.Network |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter is named network
, so you should also call it like this in the docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree
When I try out
|
The mentioned problems were already addressed. |
changes in plot.py in calc_network_expansion to plot only DC links and in v_nom