-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test out how to fix most complaints of Codacy #57
base: dev
Are you sure you want to change the base?
Commits on Nov 19, 2020
-
Prevent pylint from checking for import errors
These should be caught by our tests or `tox -e check` runs, which currently don't use pylint. Since pylint is only run via code quality checking platforms, it's ran in as without installing the package under test so getting import errors is normal.
Configuration menu - View commit details
-
Copy full SHA for 2e60cfe - Browse repository at this point
Copy the full SHA 2e60cfeView commit details
Commits on Nov 20, 2020
-
Disable pylint's import errors via ".prospector.yaml"
For some reason Codacy still mentions issues found via Prospector's pylint integration, even though I disabled it in Codacy's settings. That's why I'm trying to disable the errors directly in Prospector's configuration file. Let's see whether Codacy picks this up. Another option would be to disable running pylint through Prospector completely by using ".prospector.yaml". I should try this, should the configuration in this commit not work.
Configuration menu - View commit details
-
Copy full SHA for c1e556a - Browse repository at this point
Copy the full SHA c1e556aView commit details
Commits on Nov 21, 2020
-
Remove quotes around "MESSAGES CONTROL"
Apparently they are unnecessary because pylint also picks up the option without them present.
Configuration menu - View commit details
-
Copy full SHA for ffb093b - Browse repository at this point
Copy the full SHA ffb093bView commit details -
Fix the message disabling configuration for pep257
The message codes where missing a leading "D".
Configuration menu - View commit details
-
Copy full SHA for 9b454a0 - Browse repository at this point
Copy the full SHA 9b454a0View commit details -
Shorten '.prospector.yaml's file extension
According to Codacy's documentation, '.prospector.yaml' is legal, but since it also displays a notification that it doesn't find a configuration file for Prospector, I'm trying other variants. Using ".yml" as the extension is the first.
Configuration menu - View commit details
-
Copy full SHA for 25a733c - Browse repository at this point
Copy the full SHA 25a733cView commit details
Commits on Nov 22, 2020
-
Use
chain
instead of the bitshift operatorsSince the bitshift operators are usually side effect free, using them outside of an assignment or something similar looks like a statement without an effect to a static code checker. Using `chain` might remedy this.
Configuration menu - View commit details
-
Copy full SHA for 7531217 - Browse repository at this point
Copy the full SHA 7531217View commit details