Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test out how to fix most complaints of Codacy #57

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Commits on Nov 19, 2020

  1. Prevent pylint from checking for import errors

    These should be caught by our tests or `tox -e check` runs, which
    currently don't use pylint. Since pylint is only run via code quality
    checking platforms, it's ran in as without installing the package under
    test so getting import errors is normal.
    gnn committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    2e60cfe View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2020

  1. Disable pylint's import errors via ".prospector.yaml"

    For some reason Codacy still mentions issues found via Prospector's
    pylint integration, even though I disabled it in Codacy's settings.
    That's why I'm trying to disable the errors directly in Prospector's
    configuration file. Let's see whether Codacy picks this up.
    Another option would be to disable running pylint through Prospector
    completely by using ".prospector.yaml". I should try this, should the
    configuration in this commit not work.
    gnn committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    c1e556a View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Remove quotes around "MESSAGES CONTROL"

    Apparently they are unnecessary because pylint also picks up the option
    without them present.
    gnn committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    ffb093b View commit details
    Browse the repository at this point in the history
  2. Fix the message disabling configuration for pep257

    The message codes where missing a leading "D".
    gnn committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    9b454a0 View commit details
    Browse the repository at this point in the history
  3. Shorten '.prospector.yaml's file extension

    According to Codacy's documentation, '.prospector.yaml' is legal, but
    since it also displays a notification that it doesn't find a
    configuration file for Prospector, I'm trying other variants. Using
    ".yml" as the extension is the first.
    gnn committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    25a733c View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Use chain instead of the bitshift operators

    Since the bitshift operators are usually side effect free, using them
    outside of an assignment or something similar looks like a statement
    without an effect to a static code checker. Using `chain` might remedy
    this.
    gnn committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    7531217 View commit details
    Browse the repository at this point in the history