Skip to content

Commit

Permalink
fix: quality check issues
Browse files Browse the repository at this point in the history
  • Loading branch information
irtazaakram committed Sep 30, 2024
1 parent 519f61e commit 1a67954
Show file tree
Hide file tree
Showing 6 changed files with 55 additions and 8 deletions.
1 change: 1 addition & 0 deletions invideoquiz/__init__.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# pylint: disable=django-not-configured
"""
Runtime will load the XBlock class from here.
"""
Expand Down
3 changes: 1 addition & 2 deletions invideoquiz/invideoquiz.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def get_resource_string(path):


class InVideoQuizXBlock(StudioEditableXBlockMixin, XBlock):
# pylint: disable=too-many-ancestors
"""
Display CAPA problems within a video component at a specified time.
"""
Expand Down Expand Up @@ -165,7 +164,7 @@ def get_resource_url(self, path):
resource_url = self.runtime.local_resource_url(self, path)
return resource_url

def build_fragment(
def build_fragment( # pylint: disable=too-many-positional-arguments
self,
path_html='',
paths_css=None,
Expand Down
7 changes: 4 additions & 3 deletions pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
# SERIOUSLY.
#
# ------------------------------
# Generated by edx-lint version: 5.2.5
# Generated by edx-lint version: 5.4.0
# ------------------------------
[MASTER]
ignore =
Expand Down Expand Up @@ -259,6 +259,7 @@ enable =
useless-suppression,
disable =
bad-indentation,
broad-exception-raised,
consider-using-f-string,
duplicate-code,
file-ignored,
Expand Down Expand Up @@ -380,6 +381,6 @@ ext-import-graph =
int-import-graph =

[EXCEPTIONS]
overgeneral-exceptions = Exception
overgeneral-exceptions = builtins.Exception

# 54daa2b24c4b5341a45cdb4727fe15d05ef04c5f
# 821f7cf64aaeddd33ba92fc983426e975d2eac72
2 changes: 1 addition & 1 deletion requirements/pip_tools.txt
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ packaging==24.1
# via build
pip-tools==7.4.1
# via -r requirements/pip_tools.in
pyproject-hooks==1.1.0
pyproject-hooks==1.2.0
# via
# build
# pip-tools
Expand Down
3 changes: 3 additions & 0 deletions requirements/quality.in
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@

pycodestyle
pylint
edx-lint
pylint-django
pylint-celery
47 changes: 45 additions & 2 deletions requirements/quality.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,18 @@ asgiref==3.8.1
# -r requirements/base.txt
# django
astroid==3.3.4
# via pylint
# via
# pylint
# pylint-celery
click==8.1.7
# via
# click-log
# code-annotations
# edx-lint
click-log==0.4.0
# via edx-lint
code-annotations==1.8.0
# via edx-lint
coverage==7.6.1
# via -r requirements/test.txt
dill==0.3.9
Expand All @@ -22,6 +33,8 @@ django==4.2.16
# via
# -c requirements/common_constraints.txt
# -r requirements/base.txt
edx-lint==5.4.0
# via -r requirements/quality.in
fs==2.4.16
# via
# -r requirements/base.txt
Expand All @@ -32,6 +45,8 @@ iniconfig==2.0.0
# pytest
isort==5.13.2
# via pylint
jinja2==3.1.4
# via code-annotations
lxml==5.3.0
# via
# -r requirements/base.txt
Expand All @@ -43,6 +58,7 @@ mako==1.3.5
markupsafe==2.1.5
# via
# -r requirements/base.txt
# jinja2
# mako
# xblock
mccabe==0.7.0
Expand All @@ -53,6 +69,8 @@ packaging==24.1
# via
# -r requirements/test.txt
# pytest
pbr==6.1.0
# via stevedore
platformdirs==4.3.6
# via pylint
pluggy==1.5.0
Expand All @@ -62,7 +80,24 @@ pluggy==1.5.0
pycodestyle==2.12.1
# via -r requirements/quality.in
pylint==3.3.1
# via -r requirements/quality.in
# via
# -r requirements/quality.in
# edx-lint
# pylint-celery
# pylint-django
# pylint-plugin-utils
pylint-celery==0.3
# via
# -r requirements/quality.in
# edx-lint
pylint-django==2.5.5
# via
# -r requirements/quality.in
# edx-lint
pylint-plugin-utils==0.8.2
# via
# pylint-celery
# pylint-django
pytest==8.3.3
# via
# -r requirements/test.txt
Expand All @@ -73,13 +108,16 @@ python-dateutil==2.9.0.post0
# via
# -r requirements/base.txt
# xblock
python-slugify==8.0.4
# via code-annotations
pytz==2024.2
# via
# -r requirements/base.txt
# xblock
pyyaml==6.0.2
# via
# -r requirements/base.txt
# code-annotations
# xblock
simplejson==3.19.3
# via
Expand All @@ -88,12 +126,17 @@ simplejson==3.19.3
six==1.16.0
# via
# -r requirements/base.txt
# edx-lint
# fs
# python-dateutil
sqlparse==0.5.1
# via
# -r requirements/base.txt
# django
stevedore==5.3.0
# via code-annotations
text-unidecode==1.3
# via python-slugify
tomlkit==0.13.2
# via pylint
web-fragments==2.2.0
Expand Down

0 comments on commit 1a67954

Please sign in to comment.