Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow to setup private dbt repository #592

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: allow to setup private dbt repository #592

merged 1 commit into from
Feb 7, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 5, 2024 •
edited
Loading

Description

This PR adds a new setting to allow to setup an SSH key to clone private DBT repositories. Fixes #578

WARNING

This has been tested only on github.com.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/private-dbt-repo branch from e8e5119 to 947c98d Compare February 5, 2024 18:23
bmtcril
bmtcril approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good, and like it will work on gitlab as well. Can you also update the dbt extension / extensions docs in openedx-aspects to include this as well?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Feb 5, 2024

@bmtcril ready: openedx/openedx-aspects#115

@Ian2012 Ian2012 merged commit 47a6020 into main Feb 7, 2024
6 checks passed
@Ian2012 Ian2012 deleted the cag/private-dbt-repo branch February 7, 2024 15:05
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow private dbt repository
4 participants
@Ian2012 @openedx-webhooks @bmtcril @itsjeyd