Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use patch for clickhouse settings #575

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Jan 26, 2024

Refactor the clickhouse settings with patches, allowing it more flexibility.

Mounts file individually instead of mounting the whole users folders in k8s, allowing clickhouse to write to the file it needs to.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 26, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 26, 2024

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 force-pushed the cag/fix-clickhouse-settings branch from b30ed89 to 3b2e00c Compare January 26, 2024 20:59
@Ian2012 Ian2012 force-pushed the cag/fix-clickhouse-settings branch from 3b2e00c to 1b572a5 Compare January 26, 2024 21:29
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should comment in the patches that these only work on Tutor-based instances and not cloud hosted ones, though, just to prevent confusion.

@Ian2012 Ian2012 marked this pull request as ready for review January 29, 2024 18:42
@Ian2012 Ian2012 merged commit af838b8 into main Jan 29, 2024
6 checks passed
@Ian2012 Ian2012 deleted the cag/fix-clickhouse-settings branch January 29, 2024 18:43
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants