Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose --output-references CLI arg for building tokens, registers filters, and updates CSS vars format #3203

Merged

Commits on Sep 3, 2024

  1. feat: --output-references CLI arg for build-tokens, registers filters…

    …, and updates CSS vars format
    
    **CLI Enhancements**
    
    * Exposes `--output-references` CLI argument for `build-tokens` command. Defaults to `true`. Ensures brand package output with the CLI includes references in build output out-of-the-box.
    
    **Token Management Improvements**
    
    * Registers filter(s) `isThemeVariant.{'light'}`, handling future theme variants when implemented (e.g., `isThemeVariant.dark`).
    * Migrates `createCustomCSSVariables` to use `formattedVariables` to rely on out-of-the-box CSS variable formatting. The formatter still supports token-specific overrides of `outputReferences`. If a token has modifications via `modify`, the modified base reference is not included in the output.
    * Updates custom fileHeader implementation, including a relative path to design tokens documentation.
    * Fixes bug with line-height tokens, switching their `$type` from `dimension` to `number` to resolve typography style regressions.
    * Updates typography tokens related to font size, font weight, and line-height for more consistent naming structure when taking into account mobile.
    * Updates `@mobile-type` SCSS mixin to support level-specific customization of mobile typography styles for display 1-4.
    * Renames `"description"` field in tokens to `"$description""` per the DTCG format.
    
    **Documentation Site Enhancements**
    
    * Ensures the "Typography" foundations page properly previews the correct font size for regular "Body" text and includes the missing "HEADING LABEL" example.
    * Updates to "Colors" page in docs site:
      * Displays token name instead of CSS variable in the color swatch previews (see screenshot below).
      * Include `accent-a` and `accent-b` alongside other color names, rather than manually rendering `Swatch` for the accents.
      * Modifies the grid styles for color swatch preview to be more responsive.
    * Resolves `NaNpx` bug in `MeasuredItem` component on docs site, while computing the measurements to display for an element (e.g., font size). Instead, it renders an empty block while measurements are resolved.
    * Updates `CodeBlock` styles on docs site to add its border and background color only to the `LivePreview`, not the entire `CodeBlock` example.
    * Reduces whitespace on docs site homepage.
    * Simplifies columns on docs site header, ensuring `SiteTitle` is horizontally aligned in the center.
    adamstankiewicz committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    88a2504 View commit details
    Browse the repository at this point in the history