-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: model for upstream-downstream links #269
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @navinkarkera! This repository is currently maintained by @axim-engineering. Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
aa3e463
to
87df63e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I left a few nits/questions about some field types and naming conventions, but this is working well :)
- I tested this using the test instructions on feat: upstream-downstream entity linking edx-platform#36111
- I read through the code
-
I checked for accessibility issues by using my keyboard to navigateN/A - Includes documentation -- code comments for modules and classes
- User-facing strings are extracted for translation -- mostly, but I've noted where the model
verbose_name
fields need marking too.
eb706d7
to
89d47ca
Compare
@ormsbee Pinging you here if you want to take a look 👀 |
89d47ca
to
b6010cb
Compare
Adds models and api's for Publishable entity links.
See openedx/edx-platform#36111 for more information and testing instructions.
Related to openedx/modular-learning#243