Fix: Social auth banner #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Anton Yarmolenko <[email protected]>
Stepanokdev
suggested changes
Jan 13, 2025
| if case AuthMethod.socailAuth(let method) = authMethod { | ||
| socialAuthMethod = method.rawValue | ||
| var postLoginData: PostLoginData? | ||
| if case .socailAuth(let socialMethod) = authMethod { |
There was a problem hiding this comment.
socailAuth typo
socialAuth?
| @@ -27,6 +27,18 @@ public enum LogistrationAction: Sendable { | |||
| case register | |||
| } | |||
|
|
|||
| public struct PostLoginData: Sendable { | |||
| public var authMethod: String = "" | |||
There was a problem hiding this comment.
Maybe replace var with let?
volodymyr-chekyrta
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #558 +/- ##
========================================
Coverage ? 0
========================================
Files ? 0
Lines ? 0
Branches ? 0
========================================
Hits ? 0
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from edx#106 and fixes the display of the Social Auth Banner when What's new View is enabled. Prior to the fix, we were losing the Social Auth Banner because it was implemented with a
.userAuthorisednotification, which never happens for MainScreenViewModel