Minor changes

openedx · Nov 1, 2023 · 074b975 · 074b975
1 parent c4dd89c
commit 074b975
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/core/src/main/java/org/openedx/core/presentation/dialog/appreview/AppReviewUI.kt b/core/src/main/java/org/openedx/core/presentation/dialog/appreview/AppReviewUI.kt
@@ -265,6 +265,7 @@ fun DefaultDialogBox(
         Box(
             modifier = Modifier
                 .fillMaxSize()
+                .padding(horizontal = 12.dp)
                 .noRippleClickable {
                     onDismissClock()
                 },

diff --git a/core/src/main/java/org/openedx/core/presentation/dialog/appreview/ThankYouDialogFragment.kt b/core/src/main/java/org/openedx/core/presentation/dialog/appreview/ThankYouDialogFragment.kt
@@ -69,10 +69,12 @@ class ThankYouDialogFragment : BaseAppReviewDialogFragment() {
         val request = reviewManager.requestReviewFlow()
         request.addOnCompleteListener { task ->
             try {
-                val reviewInfo = task.result
-                val flow = reviewManager.launchReviewFlow(requireActivity(), reviewInfo)
-                flow.addOnCompleteListener { _ ->
-                    onPositiveRate()
+                if (request.isSuccessful) {
+                    val reviewInfo = task.result
+                    val flow = reviewManager.launchReviewFlow(requireActivity(), reviewInfo)
+                    flow.addOnCompleteListener { _ ->
+                        onPositiveRate()
+                    }
                     dismiss()
                 }
             } catch (e: ReviewException) {