fix: patch bugs found during bash (#135)

openedx · Feb 7, 2024 · 96dd8c8 · 96dd8c8
1 parent 37c550a
commit 96dd8c8
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/src/data/index.js b/src/data/index.js
@@ -21,8 +21,4 @@ export {
 
 export { default as reducer } from './slice';
 
-export {
-  expireExamAttempt,
-} from './slice';
-
 export { default as Emitter } from './emitter';
diff --git a/src/instructions/timed_exam/StartTimedExamInstructions.jsx b/src/instructions/timed_exam/StartTimedExamInstructions.jsx
@@ -1,10 +1,12 @@
 import React from 'react';
-import { useSelector } from 'react-redux';
+import { useDispatch, useSelector } from 'react-redux';
 import { FormattedMessage } from '@edx/frontend-platform/i18n';
 import { Button } from '@edx/paragon';
+import { startTimedExam } from '../../data';
 
 const StartTimedExamInstructions = () => {
-  const { exam, startTimedExam } = useSelector(state => state.specialExams);
+  const { exam } = useSelector(state => state.specialExams);
+  const dispatch = useDispatch();
   const examDuration = exam.total_time;
 
   return (
@@ -37,7 +39,7 @@ const StartTimedExamInstructions = () => {
       <Button
         data-testid="start-exam-button"
         variant="outline-primary"
-        onClick={startTimedExam}
+        onClick={() => dispatch(startTimedExam())}
       >
         <FormattedMessage
           id="exam.startExamInstructions.startExamButtonText"

diff --git a/src/timer/ExamTimerBlock.jsx b/src/timer/ExamTimerBlock.jsx
@@ -6,7 +6,7 @@ import CountDownTimer from './CountDownTimer';
 import { ExamStatus, IS_STARTED_STATUS } from '../constants';
 import TimerProvider from './TimerProvider';
 import {
-  Emitter, expireExamAttempt, stopExam, submitExam,
+  Emitter, expireExam, stopExam, submitExam,
 } from '../data';
 import {
   TIMER_IS_CRITICALLY_LOW,
@@ -46,17 +46,17 @@ const ExamTimerBlock = injectIntl(({ intl }) => {
   useEffect(() => {
     Emitter.once(TIMER_IS_LOW, onLowTime);
     Emitter.once(TIMER_IS_CRITICALLY_LOW, onCriticalLowTime);
-    Emitter.once(TIMER_LIMIT_REACHED, () => dispatch(expireExamAttempt));
+    Emitter.once(TIMER_LIMIT_REACHED, () => dispatch(expireExam()));
     Emitter.once(TIMER_REACHED_NULL, onTimeReachedNull);
 
     return () => {
       Emitter.off(TIMER_IS_LOW, onLowTime);
       Emitter.off(TIMER_IS_CRITICALLY_LOW, onCriticalLowTime);
-      Emitter.off(TIMER_LIMIT_REACHED, () => dispatch(expireExamAttempt));
+      Emitter.off(TIMER_LIMIT_REACHED, () => dispatch(expireExam()));
       Emitter.off(TIMER_REACHED_NULL, onTimeReachedNull);
     };
   // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, []);
+  }, [dispatch]);
 
   return (
     <TimerProvider>

diff --git a/src/timer/TimerProvider.jsx b/src/timer/TimerProvider.jsx
@@ -100,7 +100,7 @@ const TimerProvider = ({
         liveInterval = null;
       }
     };
-  }, [timeRemaining]);
+  }, [timeRemaining, dispatch]);
 
   return (
     // eslint-disable-next-line react/jsx-no-constructed-context-values