Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp: disable price edits if course has a published run #994

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

DawoudSheraz
Copy link
Contributor

PROD-4264

Description

  • Disable price edit if a course has published runs (this is temporary and will be removed)
  • Only display sitewide banner if there is some content to display. The default banner without any content was always displaying and did not look alright.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.86%. Comparing base (4a6684f) to head (160ec06).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
- Coverage   67.90%   67.86%   -0.05%     
==========================================
  Files         129      129              
  Lines        3247     3249       +2     
  Branches      941      943       +2     
==========================================
  Hits         2205     2205              
+ Misses        997      996       -1     
- Partials       45       48       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DawoudSheraz DawoudSheraz merged commit fc63106 into master Dec 20, 2024
5 of 6 checks passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/PROD-4264 branch December 20, 2024 14:40
AfaqShuaib09 added a commit that referenced this pull request Jan 2, 2025
AfaqShuaib09 added a commit that referenced this pull request Jan 7, 2025
* Revert "temp: disable price edits if course has a published run (#994)"

This reverts commit fc63106.

* chore: added back sitewide banner changes

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants