refactor: refactor formatting of data before sending to the backend #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
316
to
+327
| return { | ||
| restriction_type: null, | ||
| countries: null, | ||
| states: null, | ||
| restriction_type: courseData.location_restriction?.restriction_type || null, | ||
| countries: courseData.location_restriction?.countries || [], | ||
| states: courseData.location_restriction?.states || [], | ||
| }; | ||
| } | ||
|
|
||
| formatGeoLocationFields(courseData) { | ||
| if (courseData?.geolocation) { | ||
| return { | ||
| geoLocationName: courseData.geolocation.location_name, | ||
| geoLocationLng: courseData.geolocation.lng, | ||
| geoLocationLat: courseData.geolocation.lat, | ||
| }; | ||
| } | ||
| return { | ||
| geoLocationName: null, | ||
| geoLocationLng: null, | ||
| geoLocationLat: null, | ||
| geoLocationName: courseData.geolocation?.location_name || '', | ||
| geoLocationLng: courseData.geolocation?.lng || null, | ||
| geoLocationLat: courseData.geolocation?.lat || null, |
There was a problem hiding this comment.
This is backend data rendering on publisher. Are you sure it is working as expected, like adding [] for fields?
Comment on lines
+263
to
+275
| if (fact_1.heading && fact_2.heading) { | ||
| return [ | ||
| fact_1, fact_2, | ||
| ]; | ||
| } | ||
| if (fact_1.heading) { | ||
| return [fact_1]; | ||
| } | ||
| if (fact_2.heading) { | ||
| return [fact_2]; | ||
| } | ||
| return []; | ||
| } |
There was a problem hiding this comment.
Either both facts should be there or none. Only one fact is not allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3202
Description
In this PR, we make some changes to the formatting of data before sending it to the backend. This is done so as to ensure that the backend receives data in the format that it is expecting. This is required to enable the backend to decide whether the incoming data is different than the one present in the database or are there any real changes?