feat: upgraded to node v18, added .nvmrc and updated workflows #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BilalQamar95
force-pushed
the
bilalqamar95/node-v18-upgrade
branch
from
2ade16b to
247b6bf
Compare
… bilalqamar95/node-v18-upgrade
…component-header packages
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #712 +/- ##
=======================================
Coverage 71.30% 71.30%
=======================================
Files 75 75
Lines 1042 1042
Branches 183 183
=======================================
Hits 743 743
Misses 289 289
Partials 10 10 ☔ View full report in Codecov by Sentry. |
52 tasks
… bilalqamar95/node-v18-upgrade
… bilalqamar95/node-v18-upgrade
justinhynes
approved these changes
May 12, 2023
Mashal-m
pushed a commit
that referenced
this pull request
May 30, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated snapshots * refactor: updated snapshots
mtyaka
pushed a commit
that referenced
this pull request
Jun 9, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated snapshots * refactor: updated snapshots
MaxFrank13
pushed a commit
that referenced
this pull request
Jun 27, 2023
* feat: upgraded to node v18, added .nvmrc and updated workflows * build: updated frontend-build, frontend-platform, component-footer & component-header packages * refactor: updated snapshots * refactor: updated snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Upgrade Node Js from 16 to 18
Description
frontend-platform&frontend-buildversionsedx-internal PR
https://github.com/edx/edx-internal/pull/8337
This needs to be merged together.