test: Add Node 20 to CI matrix #1445
Conversation
| @@ -341,6 +341,7 @@ class Calculator extends Component { | |||
| <li>arccsch(4x+y)</li> | |||
| </ul> | |||
| </td> | |||
| { /* eslint-disable-next-line jsx-a11y/control-has-associated-label */ } | |||
There was a problem hiding this comment.
Let's mention why this change is needed.
There was a problem hiding this comment.
The error (A control must be associated with a text label) and the corresponding ESLint ignore might seem self-explanatory as the rule jsx-a11y/control-has-associated-label typically applies to interactive controls like buttons, inputs, or other form elements that require labels for accessibility. In this case, <td> is a table cell element, which doesn’t function as an interactive control and therefore doesn’t require a label. The eslint-disable comment was added to prevent unnecessary warnings for this specific use case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1445 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 310 310
Lines 5319 5319
Branches 1315 1315
=======================================
Hits 4669 4669
Misses 633 633
Partials 17 17 ☔ View full report in Codecov by Sentry. |
BilalQamar95
force-pushed
the
bilalqamar95/node20-upgrade-1
branch
from
3939b5a
to
3124beb
Compare
Description
As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.
See the tracking issue for further information.