Skip to content

Commit

Permalink
Merge pull request #273 from openedx/mashal-m/node-18-upgrade
Browse files Browse the repository at this point in the history
feat: upgraded to node v18, added .nvmrc and updated workflows
  • Loading branch information
zacharis278 authored Jul 7, 2023
2 parents 382024d + 5fc086b commit f93aa38
Show file tree
Hide file tree
Showing 6 changed files with 78 additions and 18,903 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lockfileversion-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ on:

jobs:
version-check:
uses: openedx/.github/.github/workflows/lockfileversion-check.yml@master
uses: openedx/.github/.github/workflows/lockfileversion-check-v3.yml@master
16 changes: 6 additions & 10 deletions .github/workflows/node-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,16 @@ on:
jobs:
tests:
runs-on: ubuntu-20.04
strategy:
matrix:
node: [16]
npm: [8.5.x]

steps:
- name: Checkout
uses: actions/checkout@v2

uses: actions/checkout@v3
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Nodejs
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}

- run: npm install -g npm@${{ matrix.npm }}
node-version: ${{ env.NODE_VER }}

- name: Install dependencies
run: npm ci
Expand Down
2 changes: 2 additions & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
18

2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Copied from https://github.com/BretFisher/node-docker-good-defaults/blob/master/Dockerfile

FROM node:16
FROM node:18

# Create app directory
RUN mkdir -p /edx/app
Expand Down
Loading

0 comments on commit f93aa38

Please sign in to comment.