-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove UpgradeButton #536
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 97.39% 96.72% -0.68%
==========================================
Files 155 155
Lines 1384 1372 -12
Branches 232 229 -3
==========================================
- Hits 1348 1327 -21
- Misses 34 43 +9
Partials 2 2 ☔ View full report in Codecov by Sentry. |
testDisabled({ isMasquerading: true, canUpgrade: false }, true); | ||
}); | ||
it('enable when all conditions are met', () => { | ||
testDisabled({ canUpgrade: true }, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
canUpgrade
seems to be closely tied to the whole Upgrade button logic and isn't being referenced in any of the other tests in this file. Is it possible that that hook can be removed in this PR as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! |
This removes the
UpgradeButton
component (#438):CourseCardActionSlot
,UpgradeButton.(test.)jsx
)