Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove UpgradeButton #536

Merged
merged 5 commits into from
Jan 13, 2025
Merged

feat: remove UpgradeButton #536

merged 5 commits into from
Jan 13, 2025

Conversation

MaxFrank13
Copy link
Member

This removes the UpgradeButton component (#438):

  • UpgradeButton is no longer the default content in the CourseCardActionSlot,
  • Removes defintion and test files (ie. UpgradeButton.(test.)jsx)
  • Removes tracking functions and any other logging utilities specific to the UpgradeButton, including event names and onClick callbacks

@MaxFrank13 MaxFrank13 requested a review from a team as a code owner December 20, 2024 14:04
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.72%. Comparing base (ce595d0) to head (9bded0a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   97.39%   96.72%   -0.68%     
==========================================
  Files         155      155              
  Lines        1384     1372      -12     
  Branches      232      229       -3     
==========================================
- Hits         1348     1327      -21     
- Misses         34       43       +9     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

testDisabled({ isMasquerading: true, canUpgrade: false }, true);
});
it('enable when all conditions are met', () => {
testDisabled({ canUpgrade: true }, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canUpgrade seems to be closely tied to the whole Upgrade button logic and isn't being referenced in any of the other tests in this file. Is it possible that that hook can be removed in this PR as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canUpgrade is still being used by the CourseBanner component (source). There is an internal ticket in our backlog for replacing this with a PluginSlot implementation (source).

However, I think it's references can be removed in this test file! So I'll go ahead and do that

@deborahgu deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 13, 2025
@jsnwesson
Copy link
Contributor

Approved!

@MaxFrank13 MaxFrank13 merged commit 777d3aa into master Jan 13, 2025
5 of 6 checks passed
@MaxFrank13 MaxFrank13 deleted the mfrank/remove-upgrade-button branch January 13, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants