-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified Order History for Ecommerce and Commercetools #370
Unified Order History for Ecommerce and Commercetools #370
Conversation
We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2u/replatforming #370 +/- ##
===================================================
Coverage ? 63.09%
===================================================
Files ? 34
Lines ? 317
Branches ? 68
===================================================
Hits ? 200
Misses ? 112
Partials ? 5 ☔ View full report in Codecov by Sentry. |
@@ -76,7 +51,7 @@ export async function getOrders(page = 1, pageSize = 20) { | |||
|
|||
return { | |||
datePlaced: date_placed, // eslint-disable-line camelcase | |||
total: total_excl_tax, // eslint-disable-line camelcase | |||
total: isNotDecimalish(total_excl_tax) ? total_excl_tax : `$${total_excl_tax}`, // eslint-disable-line camelcase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Legacy Ecomm system works in USD, the modern does Remote Currency formatting. Thus we could get bacl $12.34 AUD
instead of 12.34
.
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
* feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js
* feat: Unified Order History for Ecommerce and Commercetools (#370) * feat: Unified order history * fix: number formatting issues for order history table We now mostly trust the server and if its a pure decimal number, we assume its USD (this is to support legacy system) * fix: npx update-browserslist-db@latest --- Author: Glenn R. Martin <[email protected]> Date: Wed Feb 7 05:30:57 2024 -0500 On branch 2u/replatform-to-master You are currently cherry-picking commit bb939ff. Changes to be committed: modified: .env.development modified: .env.test modified: src/order-history/OrderHistoryPage.jsx modified: src/order-history/service.js * feat: Unified Order History Receipt URL (#371) * feat: Unified Order History Receipt URL SONIC-279 * fix: Update .env.development trailing slash is what nginx appends to URLs during routing to the appropriate service. If it is not present, no endpoint would match Co-authored-by: Shafqat Farhan <[email protected]> --------- Co-authored-by: Shafqat Farhan <[email protected]> * feat: Uniform order history for CC's Unified Order History as well as Legacy (#377) * feat: Optionally triggered Legacy vs Unified order history * fix: URL Pathing to enable OSS to function a bit simpler with a better fallback, based on Shafqat's feedback --------- Co-authored-by: Shafqat Farhan <[email protected]>
SONIC-126
THIS DIVERGES FROM MAIN/MASTER