-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Editors in a Modal (library components only) [FC-0062] #1357
base: master
Are you sure you want to change the base?
Open Editors in a Modal (library components only) [FC-0062] #1357
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
+ Coverage 92.95% 92.96% +0.01%
==========================================
Files 1037 1034 -3
Lines 19508 19510 +2
Branches 4132 4138 +6
==========================================
+ Hits 18134 18138 +4
+ Misses 1312 1310 -2
Partials 62 62 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradenmacdonald This change looks great, but it's not letting me edit library problem blocks anymore? I don't see a modal pop up when I click "edit" for these. Editing problems in a course works fine, as does editing library html and video blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bradenmacdonald.
The code is looking good!
I found a bug while trying to edit a Problem in the "blank" state. The content is rendered at the bottom of the page instead of in the modal.
Edit: Ops.. It seems to be the same bug that @pomegranited reported.
@rpenido @pomegranited Thanks for catching that bug. It should be fixed now :) |
59194e6
to
2bc53e0
Compare
@@ -42,7 +42,13 @@ const OuterWrapper: React.FC<WrapperProps> = ({ fullScreen, children }) => { | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line just above here throws a warning because some "required" props (onClose
and title
) from Paragon are missing.
<ModalDialog isOpen size="xl" isOverflowVisible={false} onClose={() => {}} title="">{children}</ModalDialog>
Or maybe it is better just to fix it in Paragon instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thank you for your work, @bradenmacdonald!
- I tested this using the instructions from the PR
- I read through the code
- I checked for accessibility issues
- Includes documentation
Description
Implements #1321
This PR changes the built-in editors so that in libraries they open in a modal, with the library partially visible behind them. Because we still have to support the legacy unit page as default, editing content in courses will continue to use the full screen editor.
Screenshots:
Testing instructions
Try the various (Text, Problem, Video) editors in libraries as well as in courses, and make sure there are no regressions.
Other information
Includes changes from #1345 - merge that one first.
Private ref: FAL-3861.